[PATCH] Add 'country CC' command to set regulatory domain

Sam Leffler sleffler at google.com
Mon Apr 18 10:28:18 EDT 2011


On Mon, Apr 18, 2011 at 2:25 AM, Jouni Malinen <j at w1.fi> wrote:
> On Fri, Apr 15, 2011 at 05:13:40PM -0700, Sam Leffler wrote:
>> With your change my dbus setter for Country needs to be changed.
>
> Hmm.. What do you mean? It seems to be doing the exact same thing as the
> control interface SET country command does now, i.e., update
> wpa_s->conf->country and call wpa_drv_set_country().
>

I'll post a patch and you can decide.

>> It so
>> happens I had similar changes to Dmitry that I was preparing (my country cmd
>> displayed the current setting w/ no args).  While you can now use "set
>> country US" how do you get the current setting?  It looks like "get" isn't
>> hooked up to a general mechanism like "set" is.
>
> Currently, the is no mechanism for showing the current country
> configuration. I would have no problems adding similar mechanism to
> reading a global parameter that SET uses. However, that alone would not
> be enough since there is no get_country() drivers_ops and
> wpa_s->conf->country may be unconfigured (0x00 0x00).

I added the get_country method to the driver api and was looking for
something to hook it up to when I hit this (something other than the
DBus api).  I added a "country" cmd to wpa_cli (like Dmitry) but made
it both get+set the CC.  After your post I just changed it to send
"SET COUNTRY foo" for the set operation.  I still need a way to get
the CC given "GET COUNTRY" doesn't work.

Let me cleanup what I've got and post it; then you can reshape it or
suggest an approach more in line with your thinking.

-Sam


More information about the HostAP mailing list