[PATCH] Add 'signal_poll' command interface
j at w1.fi
Fri Apr 15 11:53:50 EDT 2011
On Mon, Apr 11, 2011 at 02:42:01PM -0700, Dmitry Shmidt wrote:
> On Mon, Apr 11, 2011 at 12:46 PM, Jouni Malinen <j at w1.fi> wrote:
> > On Fri, Apr 08, 2011 at 10:36:39AM -0700, Dmitry Shmidt wrote:
> >> +static int wpa_supplicant_signal_poll(struct wpa_supplicant *wpa_s, char *buf,
> >> + ret = os_snprintf(buf, buflen, "RSSI=%d\nLINKSPEED=%d\n"
> >> + "NOISE=%d\nFREQUENCY=%u\nTHRESHOLD=%d\n",
> >> + si.current_signal, si.current_txrate / 1000,
> >> + si.current_noise, si.frequency,
> >> + si.above_threshold);
> > As far as the field names are concerned, RSSI may be somewhat confusing
> > since this is a signed 8-bit value in dBm at least as far as nl80211 is
> > concerned. The THRESHOLD name is even more confusing ;-).
> This field is returned from the call, so I printed it as well. It it
> is not supported, let's remove it.
It was for the CQM events and the new signal_poll ended up sharing the
same data structure. I applied this patch with the THRESHOLD line
removed for now. Should we ever get a driver_*.c that is able to fill
that value for the signal_poll() call, we can add this at the time.
Jouni Malinen PGP id EFC895FA
More information about the HostAP