Issues with new D-Bus API

Marcel Holtmann marcel at holtmann.org
Mon Jan 4 05:02:34 EST 2010


Hi Jouni,

> > > I have new bunch of patches on my GIT: git://repo.or.cz/hostap-gosc2009.git
> > > 
> > > One of the patches fixes a bug in DebugLevel setter value type, but it's
> > > irrelevant now since Marcel's patch changes DebugLevel to string (and
> > > that's fine for me).
> > 
> > sorry about that. Wasn't sure if you were working on it. And the debug
> > level numbers confused the hell out of me.
> > 
> > Jouni, how do you wanna merge this? Cherry pick the patches?
> 
> In general, I would prefer to see a patch sent to this mailing list for
> things that are ready to be applied to hostap.git so that it is clear
> both to me when things are ready and also easier for others to notice if
> someone is working on a particular area of the code. I'm fine
> cherry-picking (or well, more likely manually extracting the patch and
> if needed, cleaning it up a bit) patches from another git repository,
> but for that, please provide a list of commit ids that should be
> applied.
> 
> Keeping patches in another git repository for long time has its risks
> (and "long" here is very relative.. half a day may end up being long if
> there are lots of cleanup/new work going on in the same area like D-Bus
> code over the past couple of weeks).
> 

so besides the BSS change notification (which doesn't apply anymore), I
have send all patches to the mailing list. Just use git am to apply them
and to keep the authorship. For reference they are in this order:

[PATCH] dbus: Use simple strings for debug level
[PATCH] dbus: Replace StateChanged with PropertiesChanged signal
[PATCH] dbus: fix BSS WPS/WPA/RSN IE property getters
[PATCH] dbus: Change BSS property MaxRate to Rates
[PATCH] dbus: aggregate PropertiesChanged signals

Regards

Marcel




More information about the HostAP mailing list