[PATCH] wpa_supplicant: send a dbus reply only if requested by the caller

[Helmut Schaa]

Am Montag, 9. Februar 2009 schrieb Dan Williams:
> On Mon, 2009-02-09 at 17:12 +0100, Helmut Schaa wrote:
> > wpa_supplicant should not send a dbus reply as response to a method call if
> > no reply was requested by the caller. Sending a reply even if not requested
> > is basically no problem but triggers dbus warnings like the one below.
> > 
> > Feb  9 07:31:23 linux-gvjr dbus-daemon: Rejected send message, 2 matched rules;
> > type="error", sender=":1.129" (uid=0 pid=30228 comm="/usr/sbin/wpa_supplicant
> > -c /etc/wpa_supplicant/wp") interface="(unset)" member="(unset)" error
> > name="fi.epitest.hostap.WPASupplicant.InvalidInterface" requested_reply=0
> > destination=":1.128" (uid=0 pid=30226 comm="/usr/sbin/NetworkManager "))
> 
> Seems fine to me; upstream dbus devs recommend that language bindings
> handle the no-reply bits themselves, but of course since we're not using
> bindings here 

Exactly.

> (since wpa_supplicant itself can't link to glib or qt or 
> whatever) it's got to be done manually.
> 
> Marcel and I have talked about implementing a replacement dbus interface
> that would also support introspection;

Introspection would be indeed cool.

> which would probably fix many of 
> these warnings.

Agreed.

> Might be a good time to start using a dbus helper 
> library too.

Do you have something in mind already?

Helmut