[PATCH] wpa_gui-qt4: silence compile warning + wpsTab enable/disable

Kel Modderman kel at otaku42.de
Sun Feb 1 15:33:50 EST 2009


On Monday 02 February 2009 05:58:55 Jouni Malinen wrote:
> On Mon, Feb 02, 2009 at 03:51:49AM +1000, Kel Modderman wrote:
> 
> > Is this better?
> 
> > -		wpsTab->setEnabled(types.contains("WSC"));
> > +		wpaguiTab->setTabEnabled(wpaguiTab->indexOf(wpsTab),
> > +					 types.contains("WSC"));
> 
> Interesting.. It looks like the wpsTab->setEnabled(FALSE) grays out the
> contents of the tab, but allows the tab to be selected while
> wpaguiTab->setTabEnabled(idx, FALSE) grays out the tab selection text
> and does not allow the tab to be selected. However, if the tab gets
> selected somehow in the program, the contents of the tab is not grayed
> out.. It looks like we actually should add both of these.

Yep, agreed.

> 
> removeTab() could be even better from the UI clarity view point, but it
> would require more work to bring back the tab if needed.
> 

Agreed again.

Thanks for committing a nicer patch.

Kel.


More information about the HostAP mailing list