[PATCH] Make proactive key caching working again

Jouni Malinen j at w1.fi
Sun Jul 6 11:43:18 EDT 2008

On Wed, Jul 02, 2008 at 03:41:57PM +0200, Michael Bernhard wrote:

> Function 'wpa_sm_set_config' used the argument 'config' as the network context which is
> a pointer to a local variable of the function 'wpa_supplicant_rsn_supp_set_config'.

> The structure 'rsn_supp_config' has already a member 'network_ctx' which is now filled in
> by this patch with 'ssid'.

Thanks! This was broken when the RSN code was changed not to touch the
configuration structure directly. Your changes are indeed making this
work the way it was supposed to work. I applied this part of the patch.

> The second reason no proactive key was generated is, that each time 'wpa_sm_set_config'
> was called the network context in all pmkasa cache entries was cleared.
> To avoid this problem, a check is made if the new network context differs from the saved
> network context (in sm->network_ctx) before copying the data.

This is something that I will need to take a closer look at in order to
figure out how exactly this was supposed to work and whether something
was broken at some point or whether the original design did not work
properly. I did not yet apply this part since I'm not sure whether it
could cause some problems in practice.

Jouni Malinen                                            PGP id EFC895FA

More information about the HostAP mailing list