[PATCH]: use of IEEE80211_IOCTL_FILTERFRAME

Ted Merrill ted at atheros.com
Mon Oct 15 16:59:16 EDT 2007


It would seem the only "correct" fix would be to list every possible ioctl.
But i think that sticking with the current-size based test, plus exceptions for
those that don't follow it, should be a good enough hack.
Most ioctls have fixed data sizes and are set up to be inline if it fits;
there would be few exceptions... this appears to be the only exception
so far in this realm.
-Ted Merrill
Atheros Communications

On Thursday 11 October 2007 14:51:00 Matthew 'mentor' Bell wrote:
> On Wed, 2007-10-10 at 14:36 -0700, Ted Merrill wrote:
> > According to Atheros engineers, the IEEE80211_IOCTL_FILTERFRAME
> > ioctl (for madwifi) must be always be passed out of line (see patch).
> 
> It appears to me that in general, whether data should be passed inline
> or OOB depends on the size of data the IOCTL is expecting, not the size
> of the data that is actually there [1]. This affects all private IOCTLs,
> so should probably be fixed for the general case.
> 
> Matthew W. S. Bell
> 
> [1] linux-2.6.21/driver/core/wireles.c:963 onwards
> (ioctl_private_call()).
> 





More information about the HostAP mailing list