[PATCH] hostapd: make driver_devicescape set multi-BSS interfaces up

Jouni Malinen j at w1.fi
Fri Nov 30 23:49:41 EST 2007


On Tue, Nov 27, 2007 at 09:42:14PM +0100, Johannes Berg wrote:
> It seems that I forgot this when converting the driver to nl80211, it
> should of course set IFF_UP on all secondary BSS interfaces as well.

Is this really needed? Please note that at least my version of
driver_devicescape.c is still using management interface and as such,
the secondary BSS interfaces do not really need to be IFF_UP for
association and EAPOL messages. Furthermore, hostapd_set_iface_flags()
is setting the management interface MTU and doing this for each BSS
interface sounds unnecessary.

If EAPOL frames will be received through the BSS data interface, it
would sound reasonable to have hostapd set the interfaces up. Until that
happens, I would just leave the interface down and require some external
configuration (ifconfig, brctl, etc.) to take care of this since the
interface itself is kind of useless until it has been properly
configured. Or well, maybe it could be claimed to be of some use for
bridging frames between STAs that are associated with this BSS. In that
case, it would probably be better to split the hostapd_set_iface_flags()
function into IFF_UP/down and change-MTU parts and only call the IFF_UP
function for secondary BSSes.

-- 
Jouni Malinen                                            PGP id EFC895FA



More information about the HostAP mailing list