[PATCH]: driver_madwifi.c null ptr dereference fix

Jouni Malinen j at w1.fi
Sun Nov 18 12:05:31 EST 2007


On Wed, Oct 10, 2007 at 03:26:49PM -0700, Ted Merrill wrote:

> In tracking down a null ptr dereference fix by Atheros engineers 
> (separately fixed by others in hostapd), i came across some
> possible null pointer dereferences in debugging statements.
> Attached is patch.

Thanks! Applied.

> You might be inspired to look through the rest of the file for
> similar issues... i would but i'm not sure where NULL ptrs would
> be expected.

I went through the remaining MAC2STR() uses in the file and did not find
cases that would be called with NULL pointer.

> For extra credit, it would be nice if it were documented via comments
> whenever an NULL pointer was an acceptable argument value and 
> what it meant.

This is certainly the goal for the driver interfaces. hostapd is quite a
bit behind on this when compared to wpa_supplicant, but this will
hopefully be resolved eventually.

-- 
Jouni Malinen                                            PGP id EFC895FA



More information about the HostAP mailing list