[PATCH] Re-synchronize driver_madwifi.c ioctl order with madwifi-ng rev 1331 and later

Jouni Malinen jkmaline at cc.hut.fi
Sun Mar 19 20:34:13 EST 2006

On Fri, Mar 17, 2006 at 12:44:37PM +0100, Pieter Hollants wrote:

> In wpa_supplicant/driver_madwifi.c, rev. 1.19 added support for
> madwifi-ng's at that time new private ioctls. That was based against SVN
> rev 1298-1330 of madwifi-ng's net80211/net80211_wireless.c, in which the
> ioctl order still was SETPARAM, GETPARAM, SETKEY etc.
> However, as http://madwifi.org/changeset/1331 shows, the ioctls were
> reordered on 22 November last year, and wpa_supplicant wasn't updated so
> far to reflect these changes.

Great.. That's not exactly what I would like to see happening with
ioctl() numbers.. I applied your patches to both wpa_supplicant and
hostapd with some extra code to avoid similar changes to first/last item
in the list from causing possible buffer overflows.

Jouni Malinen                                            PGP id EFC895FA

More information about the HostAP mailing list