[PATCH] more dbus control interface functionality

Dan Williams dcbw at redhat.com
Fri Jun 23 10:18:09 EDT 2006


On Thu, 2006-06-22 at 20:04 -0700, Jouni Malinen wrote:
> On Thu, Jun 22, 2006 at 07:56:13AM -0400, Dan Williams wrote:
> 
> > I can take a stab at cleaning them up, based on your comments.  You've
> > probably got better things to do :)
> 
> Thanks, appreciated.

Updated patch is attached.

- Almost all lines <= 80 characters wide
- " (" replaced with "(" for function calls
- {} placed correctly for wpa_supplicant style
- Function declaration arguments spaced correctly for wpa_supplicant
style
- Always check wpa_zalloc() return
- Misc cleanups

BTW, not entirely sure how we should handle the install of the
"dbus-wpa_supplicant.conf" file, which needs to be copied
to /etc/dbus-1/system.d/wpa_supplicant.conf in the install stage, but
presumably only when CONFIG_CTRL_IFACE_DBUS is defined.  But we can
leave that for later.

Thanks,
Dan

-------------- next part --------------
A non-text attachment was scrubbed...
Name: more-dbus.patch.gz
Type: application/x-gzip
Size: 11647 bytes
Desc: not available
Url : http://lists.shmoo.com/pipermail/hostap/attachments/20060623/1df6bac1/attachment.bin 


More information about the HostAP mailing list