[PATCH] hw_downloading may fail to be unset

Jouni Malinen jkmaline at cc.hut.fi
Tue Feb 3 23:52:04 EST 2004


On Wed, Jan 28, 2004 at 04:05:38PM -0500, Pavel Roskin wrote:

> Some errors during genesis RAM download make it impossible to load any
> firmware until the card is reinserted.  I don't think it's a good idea.
> Another attempt to load firmware could actually succeed.

Agreed. I have seen this happening couple of times, but have been too
lazy to fix it.

> The attached patch ensures that prism2_download_genesis() always unsets
> local->hw_downloading on exit.  I'm not a big fan of "goto", but I tried
> to make code resemble prism2_download_volatile() for consistency.

Thanks, applied. prism2_download_nonvolatile() would have been a
somewhat better example. There are some cases where goto's are quite
useful in C, but I did not really understand what I have been thinking
with that extra out2 label ;-). Anyway, I removed that from both the
volatile and genesis downloads to make the function somewhat nicer to
look at.

-- 
Jouni Malinen                                            PGP id EFC895FA



More information about the HostAP mailing list