[PATCH] CardServices release does not match

Jouni Malinen jkmaline at cc.hut.fi
Mon May 26 12:55:40 EDT 2003


On Sat, May 24, 2003 at 07:46:37PM -0400, Pavel Roskin wrote:

> The attached patch exports PCMCIA_PATH and also introduces some basic
> checks to avoid common errors.

Thanks, partly applied:

> If PCMCIA_PATH is set to an invalid or missing directory, exit with an
> error.  If both CONFIG_PCMCIA and PCMCIA_PATH are set, it's an error too -
> you don't need to specify PCMCIA_PATH if kernel PCMCIA support is present.
> 
> If neither CONFIG_PCMCIA nor PCMCIA_PATH are defined, it's a warning.
> Ideally, hostap_cs shouldn't be built and installed in this case, but
> let's leave it for another patch.

OK, applied.

> There is no need to add "-I$(PCMCIA_PATH)/include" to INCLUDES in the
> top-level Makefile.  INCLUDES is only used to find KERNELRELEASE, which is
> independent of pcmcia-cs.  This still looks too complicated to me.
> Cannot we use "sed" to get UTS_RELEASE from include/linux/version.h or
> even directly from the kernel top-level Makefile?

Actually, there is need for that. I reverted your previous patch that
removed the need.. ;-). INCLUDES is still used when compiling with 'make
pccard'; this is needed for Linux 2.2.x and is optional for Linux 2.4.x.
In other words, this part of the patch was not applied.

Yeah, kernel version should be available more cleanly.. linux/version.h
is not very good place for it due to distribution-specific changes
(e.g., look what Red Hat did to this file). Parsing the version from
Linux toplevel Makefile might be better alternative. We just need to
make sure that the code doing this works with Linux 2.2.x, 2.4.x, 2.5.x
and preferable with most distribution-specific changes..

> Since depmod is run after every installed modules, make can fail because
> of unresolved symbols if the already installed modules that are about to
> be replaced.  I see two ways to avoid this problem.  One is to create
> private targets like _install_pcard without depmod and make sure that
> public targets only call depmod at the end.  Another approach is to
> introduce "uninstall" target that would remove old modules before depmod
> is run the first time.  The patch implements the second approach.

Applied.

-- 
Jouni Malinen                                            PGP id EFC895FA



More information about the HostAP mailing list