[PATCH] Inconsistency in prism2_download_genesis()

Jouni Malinen jkmaline at cc.hut.fi
Tue Dec 23 13:50:44 EST 2003


On Tue, Dec 23, 2003 at 03:25:36AM -0500, Pavel Roskin wrote:

> prism2_download_genesis() can return 1, -1 or negative error code for
> different errors.  prism2_hw_reset() calls prism2_download_genesis() and
> assumes that only negative return values are errors.
> 
> Also, the return value of prism2_download_genesis() can be returned by
> hostap_ioctl(), so it's better to use negative error codes.

Agreed.

> The patch is attached.  I don't feel strong about using EIO, feel free to
> change to another code.

Thanks, applied.

-- 
Jouni Malinen                                            PGP id EFC895FA



More information about the HostAP mailing list